Просмотр исходного кода

D3D12 GPU: Prevent reading out of bounds when uploading textures.

When the upload needs realignment, a new buffer is created to do the
upload, and the source data is copied to the new buffer. This commit
fixes the issue where the memcopy can read off the end of the source
buffer since it is reading based on destination pitch instead of source
pitch.

(cherry picked from commit 6a01d6e7d30d83ae76f567d359754749bb1c5d72)
Chris Genova 6 месяцев назад
Родитель
Сommit
5d0919855e
1 измененных файлов с 1 добавлено и 1 удалено
  1. 1 1
      src/gpu/d3d12/SDL_gpu_d3d12.c

+ 1 - 1
src/gpu/d3d12/SDL_gpu_d3d12.c

@@ -5953,7 +5953,7 @@ static void D3D12_UploadToTexture(
                 SDL_memcpy(
                     temporaryBuffer->mapPointer + (sliceIndex * rowsPerSlice) + (rowIndex * alignedRowPitch),
                     transferBufferContainer->activeBuffer->mapPointer + source->offset + (sliceIndex * bytesPerSlice) + (rowIndex * rowPitch),
-                    alignedRowPitch);
+                    rowPitch);
             }
             Uint32 offset = source->offset + (sliceIndex * bytesPerSlice) + ((rowsPerSlice - 1) * rowPitch);
             SDL_memcpy(