Browse Source

notification: Check the icon string before duplicating

Fixes #15877
Frank Praznik 1 day ago
parent
commit
a7ade74cf1
1 changed files with 2 additions and 2 deletions
  1. 2 2
      src/notification/unix/SDL_dbusnotification.c

+ 2 - 2
src/notification/unix/SDL_dbusnotification.c

@@ -595,13 +595,13 @@ static const char *GetIconURI()
     SDL_PropertiesID props = SDL_GetGlobalProperties();
     SDL_PropertiesID props = SDL_GetGlobalProperties();
     const char *icon = SDL_GetStringProperty(props, SDL_PROP_GLOBAL_NOTIFICATION_HEADER_ICON_STRING, NULL);
     const char *icon = SDL_GetStringProperty(props, SDL_PROP_GLOBAL_NOTIFICATION_HEADER_ICON_STRING, NULL);
     if (icon && realpath(icon, full_path)) {
     if (icon && realpath(icon, full_path)) {
-        size_t len = SDL_strlen(full_path) + 8;
+        const size_t len = SDL_strlen(full_path) + 8;
         icon_uri = SDL_malloc(len);
         icon_uri = SDL_malloc(len);
         if (icon_uri) {
         if (icon_uri) {
             SDL_strlcpy(icon_uri, "file://", len);
             SDL_strlcpy(icon_uri, "file://", len);
             SDL_strlcat(icon_uri, full_path, len);
             SDL_strlcat(icon_uri, full_path, len);
         }
         }
-    } else {
+    } else if (icon) {
         // If the path can't be retrieved, assume it is the system name of an icon.
         // If the path can't be retrieved, assume it is the system name of an icon.
         icon_uri = SDL_strdup(icon);
         icon_uri = SDL_strdup(icon);
     }
     }